svitalis123 / Book-an-Appointment

5 stars 2 forks source link

Kanban board #12

Open shuhad786 opened 1 year ago

shuhad786 commented 1 year ago
Meltrust commented 1 year ago

Hi @topeogunleye,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

You can do it

Required Changes ♻️

According to the project requirements:

image

However, I can see the tasks do not include any points prefixes.

Therefore:

[2pt] Setup Rails Backend API

Kindly, ensure that the points among your team members are distributed so nobody has 5 points more than anyone on the team.

That way, we will meet this particular requirement. 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Meltrust commented 1 year ago

Hi @shuhad786,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

You can do it

Required Changes ♻️

@amon-cofie 14.5 @shuhad786 17.5 @svitalis123 17.5 @Estherstarr 19 @topeogunleye 22

As you can see, @topeogunleye has 8.5 points more than @amon-cofie.

The requirement states that no team member can have more than 5 (five) points more than anyone else on the team.

Kindly, correct the paintings so they meet this particular requirement.

Tip: Just change some paintings and/or reassign some tasks.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Meltrust commented 1 year ago

Hi @topeogunleye,

Wow, you did it 🎉

Brilliant

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️

Well done!

Congratulations! 🎉

To highlight

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.