Open GoogleCodeExporter opened 9 years ago
Original comment by kurka.da...@gmail.com
on 13 Jul 2011 at 8:22
Original comment by kurka.da...@gmail.com
on 13 Jul 2011 at 8:23
I'm about to implement the code for
navigator.notification.loadingStart()
navigator.notification.loadingStop()
navigator.notification.activityStart()
navigator.notification.activityStop()
I plan to clone your repository. Let me know how you'd like me to proceed.
Original comment by ambr...@gmail.com
on 31 Aug 2011 at 3:50
if you like to implement put your clone url here and I will pull und review
your changes
Original comment by kurka.da...@gmail.com
on 31 Aug 2011 at 4:00
Here's my clone URL:
git clone https://code.google.com/r/ambrons-notification-enhancement/
I don't know if you've looked, but they pulled the loading* and activity* code
from notification and moved it into a plugin NotificationEx. It currently only
works for iOS. I'm going to implement it for Android as well. So it's
consistant for at least the big too.
I'm going to follow the precedent you've set for plugins so it should be
consistant with what you have used on badge and childbrowser.
Original comment by ambr...@gmail.com
on 31 Aug 2011 at 8:10
I just took a look myself. At least in trunk they still have those calls
present in phonegap.js (See:
https://github.com/phonegap/phonegap/blob/master/Android/phonegap-1.0.0.js)
I am quite unsure which way to go here. Maybe we should clarify with phonegap
team first.
Anyway if you like to proceed lets start as a plugin (it should`t to much work
to move the code later to notification if we need it)
Put a note here when you are done, so I can pull your changes
Original comment by kurka.da...@gmail.com
on 31 Aug 2011 at 8:59
I was looking in the iOS phonegap-1.0.0.js file. I didn't check the android
version of the core is file for 1.0.0.
Here's the ticket I was referencing about it being moved to a plugin.
https://github.com/phonegap/phonegap-iphone/issues/153
https://github.com/phonegap/phonegap-iphone/issues/155
https://github.com/phonegap/phonegap-plugins/tree/master/iPhone/NotificationEx
I'll let you know when it is committed. I may also put a feeler out to phonegap
to figure out direction. Seems like it might not have been deprecated
consistantly across platforms.
Original comment by ambr...@gmail.com
on 31 Aug 2011 at 10:40
Original comment by kurka.da...@gmail.com
on 10 Oct 2011 at 12:03
Sorry I haven't abandoned this work, I was just busy somewhere else. I should
be in a position t dedicate some time to this in the next two weeks.
Original comment by ambr...@gmail.com
on 17 Oct 2011 at 2:58
Original issue reported on code.google.com by
kurka.da...@gmail.com
on 16 May 2011 at 1:42