svlad-90 / DLT-Message-Analyzer

"Extended search" plugin for the DLT-viewer
Other
76 stars 13 forks source link

[FILTERS_VIEW] Bugs in PCRE interpretation of the filter's view #98

Closed svlad-90 closed 4 years ago

svlad-90 commented 4 years ago

Filter's view considers the negative, positive look-behind and look-ahead as groups. image

That is wrong. The expected behavior is:

The first approach seems to be more feasible ( as it is more simple ). But, anyway, we first should be able to properly parse the regex. ANTLR can help with that. We can use ANTLR together with the following description of RPCE to generate a parser: https://github.com/bkiers/pcre-parser

The parser can be used to simplify the hand-written part of the source code. This change should be applied, as its absence locks the following task - https://github.com/svlad-90/DLT-Message-Analyzer/issues/82

svlad-90 commented 4 years ago

antlr4 & PCRE grammar were added to the project. A call to antlr4 generator was included in the build.

Next step is to:

svlad-90 commented 4 years ago

Some of the issues were resolved with the latest PR related to this task. The only thing that we additionally need to do in terms of this task is to start the usage of antlr PCRE parser in order to build the filter view's tree.

svlad-90 commented 4 years ago

The project's structure was refactored to reflect sub-folders: https://github.com/svlad-90/DLT-Message-Analyzer/pull/101

svlad-90 commented 4 years ago

Required functionality was finally properly supported. This task can be closed. Hura! ))