search

svnlabs / google-caja

Automatically exported from code.google.com/p/google-caja
0 stars 1 forks source link

Fix remaining uses of Object.prototype.toString.call as a brand test to do something else. #1955

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As of this writing, Object.prototype.toString.call(specimen) is still a 
reliable brand test on all deployed browsers, but TC39 recently agreed on a 
change so that it would no longer be. 

Uses in SES fixed at r5708. Remaining uses at least in 
cajaTamingGoogleLoader.js and taming-membrane.js, either of which may actually 
be safe.

Original issue reported on code.google.com by erights on 15 Feb 2015 at 6:54

GoogleCodeExporter commented 9 years ago 
https://codereview.appspot.com/202140043/

Original comment by kpreid@google.com on 18 Feb 2015 at 11:07

GoogleCodeExporter commented 9 years ago 
@r5710

All other uses of Object.prototype.toString are harmless.

Original comment by kpreid@google.com on 18 Feb 2015 at 11:39