Missing npm dependency 'request'?

svnm / react-router-redux-example

react, redux, react-router, reselect, css-modules

205 stars 54 forks source link

Missing npm dependency 'request'? #12

Closed coatsbj closed 7 years ago

coatsbj commented 7 years ago

Hey there,

Thanks for putting this together...really awesome example! Just FYI, upon running per the instructions in the readme (and npm run dev, etc.), received an error about module 'request' not found. Traced it down to ./src/api/routes/npmPackages.js, using the request node package there and sure enough, wasn't listed in package.json.

Just thought I'd let you know. Cheers!

svnm commented 7 years ago

Cool thanks @coatsbj for that, I have updated added request to package.json in latest version, also moved away from superagent to fetch. 👍