search

svnm / react-router-redux-example

react, redux, react-router, reselect, css-modules
205 stars 54 forks source link

always show loader to prevent prev package from flickering #3

Closed bigethan closed 8 years ago

bigethan commented 8 years ago

When browsing packages, the previously clicked package would appear for a bit while the click package loaded. This change ensures that the loader always appears when loading a new package.

Also removed fetchData() as it wasn't being used.

svnm commented 8 years ago

wait, I think we need the static fetchData() as it is used in the server rendering to fetch the data, If you have a look here. If you want to try another commit with just the update to the loader, I can give it a try. Thanks

bigethan commented 8 years ago

All updated, thanks for the catch!