search

svpbde / svpb

Some simple Django webapps for our sailing club
Apache License 2.0
0 stars 0 forks source link

Fix or remove offline mode #29

Open transistortim opened 9 months ago

transistortim commented 9 months ago

Offline mode (settings.OFFLINE) is currently broken due to some changes I made some time ago (didn't note it then).

Do we actually need it? The offline mode just hides the login page, but does not invalidate active sessions, which would be required to have a clean "maintenance mode". When I'm doing maintenance work, I stop resp. restart the service anyway, so an offline mode build into the app itself wouldn't help.

This might have been useful in the past, but at the moment I tend to completely remove it instead of fixing an unused feature.

transistortim commented 9 months ago

As it actually happened this year that somebody submitted a Meldung from his still valid session after login was deactivated, I think not invalidating sessions is an issue :angel: