search

svrcekmichal / redux-axios-middleware

Redux middleware for fetching data with axios HTTP client
MIT License
920 stars 96 forks source link

add webpack build for UMD #40

Closed crobinson42 closed 7 years ago

crobinson42 commented 7 years ago

Can you implement or will you accept a PR adding a webpack build into the package for UMD support? This would be great for your package, for example, I wanted to realtime code demo the features today to a client using Cloud9 or Kobra.io but couldn't use this library with a script tag via https://unpkg.com/redux-axios-middleware@3.0.0/ because it's only built for commonJs.

nmaves commented 7 years ago

I don't have an issue with this. Port something together and we will take a look.

On Tue, Feb 7, 2017, 9:33 PM Cory Robinson notifications@github.com wrote:

Can you implement or will you accept a PR adding a webpack build into the package for UMD support? This would be great for your package, for example, I wanted to realtime code demo the features today to a client using Cloud9 or Kobra.io but couldn't use this library with a script tag via https://unpkg.com/redux-axios-middleware@3.0.0/ because it's only built for commonJs.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/svrcekmichal/redux-axios-middleware/issues/40, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWchu0sXn4FnBEZ-bAxUsh-JtxqjUrjks5raUWXgaJpZM4L6X6K .

crobinson42 commented 7 years ago

PR - see #41

crobinson42 commented 7 years ago

feature release recommend 3.1.0 publish**

nmaves commented 7 years ago

This will be included in the 3.1 release.