search

svrcekmichal / redux-axios-middleware

Redux middleware for fetching data with axios HTTP client
MIT License
918 stars 96 forks source link

adding basic typings support so the package can be imported and used i…n typescript environment, I didn't make all types available just the basic. #69

Closed vasilevich closed 5 years ago

vasilevich commented 7 years ago

Added a starting point for typescript typings so that you can do:

import axiosMiddlewareCreator from 'redux-axios-middleware';
export const axiosMiddleware = axiosMiddlewareCreator(axios);

please note: this does not include ALL the types of axiosMiddleware, I hope somebody can take the time and make the rest of the types, because I am not sure how to do it.

Thank you and best of luck!

andrewjrhill commented 5 years ago

Can we get an update on this PR please?

edit: @svrcekmichal no longer appears to be active on this repository - it hasn't received an update since 2017.

kg-currenxie commented 5 years ago

Yes plz!

vasilevich commented 5 years ago

these typings served me well, unfortunately, the maintainer of this repo (and the NPM module) is no longer active. but if you want you can use my fork in your NPM project simpley by writing: yarn add https://github.com/vasilevich/redux-axios-middleware.git#53373f5d0027bc914c1ceb85cc173b3137d24e13

this should work almost exactly like NPM with a specific version (in this case 53373f5d0027bc914c1ceb85cc173b3137d24e13 is the commit)

if you think it is reasonable and not disrespectful to the creator of this repo, I could simpley make a new NPM under a new name with the added features, otherwise this github will have to do.

Cheers.

svrcekmichal commented 5 years ago

sorry guys for late response, the only way I can help you is to make you collaborator of the repo? would that work for you? if not, you can freely fork this as you already did

vasilevich commented 5 years ago

yes, please add me as a collaborator, and if you can, also add me as a collaborator on the NPM package so that I can push the changes to NPM repository. my account on npm.org is same as here: vasilevich

https://www.npmjs.com/~vasilevich

Thanks for your short notice answer.

svrcekmichal commented 5 years ago

@vasilevich you should be added, thanks for taking your time to work on this repository. I really appreciate that even if I no longer have time to do that.

vasilevich commented 5 years ago

I merged & published the changes to NPM should have the typings now.

Thanks for your cooperation @svrcekmichal

knightus commented 5 years ago

@vasilevich can you also create the version tag on github accordingly. I've seen 4.0.1 in npm but not in github so it's hard to acknoledge the changes until I see the commit history