svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
84 stars 18 forks source link

Add test for channel map set parsing #103

Closed gauthierm closed 3 years ago

gauthierm commented 3 years ago

Adds an integration tests for parsing channel map set information in the get zone group state function.

A future update that would be nice is to split the parsing functions into separate files or classes so they can be tested independently rather than as an integration test.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 458723305


Totals Coverage Status
Change from base Build 452489776: 0.3%
Covered Lines: 1150
Relevant Lines: 1520

💛 - Coveralls
svrooij commented 3 years ago

Because I changed the branch where the PR should merge into it failed to send to code to coveralls. (need a solution for that, but the actual tests succeed!!).

So thank you @gauthierm for your first contribution! It will be included in the next beta, and that gets merged into latest soon! 🎉

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.3.0-beta.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: