svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
81 stars 18 forks source link

#Album with AddURIToQueue does not work #108

Closed hklages closed 3 years ago

hklages commented 3 years ago

With node-sonos-ts I am not able to add the following URI to SONOS queue neither with valid metadata nor without. I tried: "AddUriToQueue" but also from "AVTransportService" and with direct execute.

{
    "InstanceID": 0,
    "EnqueuedURI": "x-rincon-playlist:RINCON_000E58FE3AEA01400#A:ALBUM/Diamond%20Life",
    "EnqueuedURIMetaData": "",
    "DesiredFirstTrackNumberEnqueued": 0,
    "EnqueueAsNext": 1
}

It works fine in node-sonos.

Looking at the generated SOAP request there is a small difference - two times "\r\n" or do you see any other differences?

SOAP body generated in nodes-sonos-ts causing an error message: "<s:Envelope xmlns:s=\"http://schemas.xmlsoap.org/soap/envelope/\" s:encodingStyle=\"http://schemas.xmlsoap.org/soap/encoding/\">\r\n<s:Body><u:AddURIToQueue xmlns:u=\"urn:schemas-upnp-org:service:AVTransport:1\"><InstanceID>0</InstanceID><EnqueuedURI>x-rincon-playlist:RINCON_000E58FE3AEA01400#A%3aALBUM/Diamond%20Life</EnqueuedURI><EnqueuedURIMetaData></EnqueuedURIMetaData><DesiredFirstTrackNumberEnqueued>0</DesiredFirstTrackNumberEnqueued><EnqueueAsNext>1</EnqueueAsNext></u:AddURIToQueue></s:Body>\r\n</s:Envelope>"

versus the one which works: "<s:Envelope xmlns:s=\"http://schemas.xmlsoap.org/soap/envelope/\" s:encodingStyle=\"http://schemas.xmlsoap.org/soap/encoding/\"><s:Body><u:AddURIToQueue xmlns:u=\"urn:schemas-upnp-org:service:AVTransport:1\"><InstanceID>0</InstanceID><EnqueuedURI>x-rincon-playlist:RINCON_000E58FE3AEA01400#A:ALBUM/Diamond%20Life</EnqueuedURI><EnqueuedURIMetaData></EnqueuedURIMetaData><DesiredFirstTrackNumberEnqueued>0</DesiredFirstTrackNumberEnqueued><EnqueueAsNext>1</EnqueueAsNext></u:AddURIToQueue></s:Body></s:Envelope>"

svrooij commented 3 years ago

3AEA01400#A%3aALB There is a difference in the url encoding %3a vs :

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 2.3.0-beta.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: