fix: Add apple music metadata

svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.

https://sonos-ts.svrooij.io/

MIT License

81 stars 18 forks source link

fix: Add apple music metadata #109

Closed ryanolf closed 3 years ago

ryanolf commented 3 years ago

Updated the URI and metadata guessing to allow simplified Apple Music URIs, similar to existing Spotify and Deezer support.

Apple Music uses different URIs depending on whether an item is taken from the user's music library or from the broader service. This pull request includes support for both types of content.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 478283578

30 of 32 (93.75%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 77.852%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/helpers/metadata-helper.ts	30	32	93.75%
<!--	Total:	30	32	93.75%	-->

Totals
Change from base Build 459194923:	0.6%
Covered Lines:	1228
Relevant Lines:	1595

And one more tip, this library uses sematic releases. So if your last commit message would start with fix: Support for apple music guessing (of fix: Something else the first part is important). It would auto-release a new (beta) version after merge.

This would also mean there will be a note in the release notes about apple music

Did you find it hard to figure out how you needed to generate these statement, and should I document this better? Suggestions?

ryanolf commented 3 years ago

@svrooij I didn't know about the significance of the beginning of the commit message. Perhaps it's in the docs. I'm not familiar with automatic releases based on commit message semantics.

I think you can put comments/instructions in a pull request template with the information that you just shared -- that way anyone who submits a pull request will see it and understand that it is relevant.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.3.0-beta.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: