svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
84 stars 18 forks source link

Event errors and invisible bug #129

Closed svrooij closed 3 years ago

svrooij commented 3 years ago

Description

This PR fixes the #127 bug, by emitting an event if the subscription is unsuccessful. It also fixes #125 by better parsing zone groups.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

💔 Thank you!

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 551636531


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sonos-device.ts 14 15 93.33%
src/services/base-service.ts 14 16 87.5%
src/sonos-event-listener.ts 20 23 86.96%
<!-- Total: 60 66 90.91% -->
Files with Coverage Reduction New Missed Lines %
src/services/base-service.ts 2 90.83%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 504514344: -0.02%
Covered Lines: 1454
Relevant Lines: 1856

💛 - Coveralls
github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.4.0-beta.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: