search

svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
84 stars 18 forks source link

BUG: Spotify playlist Zu Hause throws an error. #137

Closed hklages closed 3 years ago

hklages commented 3 years ago

What happened

Queuing a spotify playlist throws an error. Playlist is valid Zu Hause

What did you expect to happen

Members of that playlist to be added to SONOS queue

How to reproduce it (minimal and precise)

command: AddUriToQueue Playlist: spotify:user:spotify:playlist:37i9dQZF1DX1htCFhfVtyK

Debug logging

"group.queue.urispotify:Sonos error on AddURIToQueue UPnPError 804 (undefined) :: Details: {"stack":"SonosError: Sonos error on AddURIToQueue UPnPError 804 (undefined)
 at AVTransportService.handleErrorResponse (/usr/local/addons/redmatic/var/node_modules/node-red-contrib-sonos-plus/node_modules/@svrooij/sonos/lib/services/base-service.js:231:23)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async AVTransportService.handleRequestAndParseResponse (/usr/local/addons/redmatic/var/node_modules/node-red-contrib-sonos-plus/node_modules/@svrooij/sonos/lib/services/base-service.js:204:15)
at async AVTransportService.SoapRequestWithBody (/usr/local/addons/redmatic/var/node_modules/node-red-contrib-sonos-plus/node_modules/@svrooij/sonos/lib/services/base-service.js:97:16)
at async AVTransportService.AddURIToQueue (/usr/local/addons/redmatic/var/node_modules/node-red-contrib-sonos-plus/node_modules/@svrooij/sonos/lib/services/av-transport.service.js..."

Environment

Checklist

Please confirm the following before creating the issue.

svrooij commented 3 years ago

The URL isn't correct.....

All spotify urls I've seen are in the following format spotify:{kind}:{id} all the supported urls are tested here

The guessing of meta data is described here

hklages commented 3 years ago

That format used to work but now also your example does not work anymore (from old node - sonos)

Have to explore more.

spotify playlists

svrooij commented 3 years ago

I think the sample was incorrect, there is no code to parse that url and generate metadata. The code is mainly copied and improved upon from the old library.

hklages commented 3 years ago

Could it be that your test case works because a "c" is missing after the 206 and before "spotify"

Are you able to play that playlist on your player?

missingC

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 2.4.1-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

hklages commented 3 years ago

confirmation: beta-.3 fixes that issue.

My 5 test cases (album, track, toptrack AND playlist) works fine and add the tracks to the queue.

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 2.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: