svrooij commented 2 years ago

The SSDP discovery was broken

Description

We used a static port 1900, because we thought it was needed. Apparently you'll get the response to whatever port you have send the message from. So any random port will do. This should make the discovery much more stable and super fast.

Fixed #150

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

[X] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[X] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
[X] Check the commit's or even all commits' message styles matches our requested structure.
[ ] Check your code additions will fail neither code linting checks nor unit test.
[X] Check you add tests for added code.

💔 Thank you!

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1666891893

7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 78.115%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/sonos-device-discovery.ts	7	8	87.5%
<!--	Total:	7	8	87.5%	-->

Totals
Change from base Build 1645851143:	0.03%
Covered Lines:	1533
Relevant Lines:	1939

💛 - Coveralls

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.5.0-beta.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: