svrooij commented 2 years ago

Restore after notification

Description

With this PR a failure in notifications should never result in a state where you cannot play any more notifications. There is now a catch around all the actions when playing the notification and also for the restore action.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] Check you add tests for added code.

💔 Thank you!

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1699400871

6 of 10 (60.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 81.358%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/sonos-device.ts	6	10	60.0%
<!--	Total:	6	10	60.0%	-->

Totals
Change from base Build 1671685809:	-0.1%
Covered Lines:	1621
Relevant Lines:	1951

💛 - Coveralls

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.5.0-beta.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: