svrooij commented 2 years ago

New feature allows starting with a hostname, will resolve automatically

Description

This PR implements support for hostnames.

SonosManager will automatically resolve a hostname to an IP when calling InitializeFromDevice
BaseService will auto resolve each call to a sonos speaker when host is not an ip.

It's recommended to resolve the IP yourself, because that way it will only happen once. And not several times per device (as in once per each called service).

const IpHelper = require('@svrooij/sonos').IpHelper;

const ip = await IpHelper.ResolveHostname('some-sonos-host');

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] Check you add tests for added code.

💔 Thank you!

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1841048842

27 of 31 (87.1%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 81.385%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/helpers/ip-helper.ts	11	13	84.62%
src/index.ts	0	2	0.0%
<!--	Total:	27	31	87.1%	-->

Totals
Change from base Build 1699413240:	0.03%
Covered Lines:	1646
Relevant Lines:	1980

💛 - Coveralls

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.5.0-beta.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: