search

svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
84 stars 18 forks source link

Question: Spotify Region US #163

Closed hklages closed 4 months ago

hklages commented 2 years ago

In your code I was able to find the "spotifyRegion" parameter with default for Europe = "2311".

Is it possible to set the region to US = "3079"? How?

hklages commented 2 years ago

Having had a closer look at your code it does not seem to be possible to set the region.

Suggestion:

Add additional optional parameter spotifyRegion to methods

and pass that parameter to GuessMetaDataAndTrackUri

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.5.1-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

svrooij commented 2 years ago

@hklages With the latest beta, you can set the environment variable SONOS_REGION_SPOTIFY as described here

hklages commented 2 years ago

Thanks!

It will take a bit to test it. The user requests comes from New Zealand - seems that there the US region also works. Have to check with them and will let you know.

svrooij commented 2 years ago

@hklages maybe the regions should be called differently. Like Europe and Rest

At least now they are configurable. The metadata helper is also public so you should be able to call it yourself.

I was thinking to maybe make a way to automatically send metadata and track uri to some server (opt-in) and then also try to resolve a track uri to metadata server side. That way we can start supporting way more music services without the need to manually export data like you proposed.

hklages commented 2 years ago

Region naming: Lets wait - maybe there is a region Asia or Arabia. And instead of "Rest" I prefer "Non-Europe". Rest sounds a bit unfriendly (personal point of view)

My recommendation is to add that song, album, playlist to My Sonos (favorites) and then launch it with from there by title instead of extracting the spotify number and build the metadata. My Sonos is so easy to and supports all music services, is always updated by Sonos, generates the metadata --- and I dont have to maintain it :-)

Again: Thanks for providing a solution. I just published 6.4.0 and lets see whether that works for the guys.