feat: Notifications through AudioClip - Githubissues

svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.

https://sonos-ts.svrooij.io/

MIT License

85 stars 18 forks source link

feat: Notifications through AudioClip #175

Closed svrooij closed 1 year ago

svrooij commented 1 year ago

fixed: #67 (really old issue)

Description

Thank to thomas for finding a way to access the websocket api on the local network

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[ ] Check you add tests for added code.

💔 Thank you!

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4184621167

1 of 23 (4.35%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.02%) to 80.537%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/sonos-device.ts	1	23	4.35%
<!--	Total:	1	23	4.35%	-->

Totals
Change from base Build 3969443668:	-1.02%
Covered Lines:	1685
Relevant Lines:	2044

💛 - Coveralls

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.6.0-beta.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: