svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.

https://sonos-ts.svrooij.io/

MIT License

81 stars 18 forks source link

Update some packages and apply needed compliance to xmlParser Changes #180

Closed theimo1221 closed 1 year ago

theimo1221 commented 1 year ago

Your title here

Update to adress fast-xml security vulnerability

Description

This PR updates the package and contains needed changes to comply to new functionality of the library.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[ ] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] Check you add tests for added code.

💔 Thank you!

svrooij commented 1 year ago

[ ] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.

☝️?

And are the License issues with the parser resolved? A long time ago the author suddenly changed the license to be something proprietary, that made me pick the last version with the MIT license and never update.

After this PR, if you change it to the beta branch, I’ll create a new none beta release with all the changes and this change.

theimo1221 commented 1 year ago

[ ] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.

☝️?

I haven't done it against beta, as this is more a security fix than a new feature (thus better suited for master than for beta).

And are the License issues with the parser resolved? A long time ago the author suddenly changed the license to be something proprietary, that made me pick the last version with the MIT license and never update.

Should be resolved with this change to the license: https://github.com/NaturalIntelligence/fast-xml-parser/commit/1357c5d5073ead70e0cd3fa5938a704694c728df

After this PR, if you change it to the beta branch, I’ll create a new none beta release with all the changes and this change.

Okay, I'll change the base branch later today.

theimo1221 commented 1 year ago

See #181