svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.

https://sonos-ts.svrooij.io/

MIT License

84 stars 18 forks source link

Update some packages and apply needed compliance to xmlParser Changes #181

Closed theimo1221 closed 9 months ago

theimo1221 commented 1 year ago

Your title here

Update to adress fast-xml security vulnerability

Description

This PR updates the package and contains needed changes to comply to new functionality of the library.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[x] Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] Check you add tests for added code.

💔 Thank you!

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5237395584

19 of 20 (95.0%) changed or added relevant lines in 3 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.6%) to 79.959%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/helpers/xml-helper.ts	8	9	88.89%
<!--	Total:	19	20	95.0%	-->

Files with Coverage Reduction	New Missed Lines	%
src/sonos-device.ts	6	69.77%
<!--	Total:	6		-->

Totals
Change from base Build 4185799862:	-0.6%
Covered Lines:	1686
Relevant Lines:	2052

💛 - Coveralls

theimo1221 commented 1 year ago

Hello @svrooij

Can I assist you in any way to get this into main?

Thanks and best regards

Thiemo

svrooij commented 9 months ago

Closing in favor off a better replacement.... https://github.com/svrooij/node-sonos-ts/compare/v2.6.0-beta.6...v2.6.0-beta.7