svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
84 stars 18 forks source link

Use zone events instead of pull #183

Closed svrooij closed 1 year ago

svrooij commented 1 year ago

Sonos manager now falls back onto using events if fetching all groups fail

Description

Large systems, with 20+ speakers, would no longer answer to the GetParsedZoneGroupState() method of the ZoneGroupService, but they do send out events. Those events also include all the details that are required for loading the entire system. For now this PR uses the events as a fallback. So if fetching fails, it will try with events.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

💔 Thank you!

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5474429705


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sonos-manager.ts 4 14 28.57%
<!-- Total: 12 22 54.55% -->
Files with Coverage Reduction New Missed Lines %
src/sonos-device.ts 41 77.05%
<!-- Total: 41 -->
Totals Coverage Status
Change from base Build 4185799862: 0.7%
Covered Lines: 1692
Relevant Lines: 2039

💛 - Coveralls
github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.6.0-beta.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: