svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
81 stars 18 forks source link

Update some packages and apply needed compliance to xmlParser Changes (src:@theimo1221) #185

Closed simojenki closed 7 months ago

simojenki commented 7 months ago

Update to adress fast-xml security vulnerability

Description

This PR updates the package and contains needed changes to comply to new functionality of the library.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

💔 Thank you!

svrooij commented 7 months ago

It fails on some of the AlarmClockService tests. image

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7661401338


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/helpers/xml-helper.ts 8 9 88.89%
<!-- Total: 19 20 95.0% -->
Files with Coverage Reduction New Missed Lines %
src/sonos-device.ts 6 70.92%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 5474567724: -0.6%
Covered Lines: 1694
Relevant Lines: 2070

💛 - Coveralls
svrooij commented 7 months ago

No more fast-xml-parser..... https://github.com/svrooij/node-sonos-ts/compare/v2.6.0-beta.6...v2.6.0-beta.7