svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
84 stars 18 forks source link

Removing old `fast-xml-parser` in favor of `@rgrove/parse-xml` #187

Closed svrooij closed 9 months ago

svrooij commented 9 months ago

old xml parser was broken and update did not work as expected

Description

Removing the fast-xml-parser in favor of @rgrove/parse-xml so everybody can safely install the next version of node-sonos-ts without any warnings about deprecated stuff

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

💔 Thank you!

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7817128057


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sonos-event-listener.ts 1 2 50.0%
src/services/base-service.ts 32 34 94.12%
src/helpers/xml-helper.ts 40 50 80.0%
<!-- Total: 93 106 87.74% -->
Files with Coverage Reduction New Missed Lines %
src/helpers/xml-helper.ts 1 83.57%
src/sonos-event-listener.ts 14 64.05%
src/sonos-device.ts 24 66.12%
<!-- Total: 39 -->
Totals Coverage Status
Change from base Build 5474567724: -2.4%
Covered Lines: 1691
Relevant Lines: 2110

💛 - Coveralls
github-actions[bot] commented 9 months ago

:tada: This PR is included in version 2.6.0-beta.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: