search

svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
84 stars 18 forks source link

BUG: Subscription to (simple) Mute provides the false if muted. #194

Closed hklages closed 6 months ago

hklages commented 6 months ago

What happened

After having moved from 2.5.0 to 2.6.0-beta-10 the mute subscription provides wrong data: (by the way beta-10 does not show up on the top instead beta-9 is on top of releases in Github)

What did you expect to happen

Should be true if player changes from unmute to mute.

How to reproduce it (minimal and precise)

  1. Subcribe to RenderingControl service for a specific player (.Events.on)
  2. change mute state to mute output is always "false"

GroupRenderingControl works fine.

Debug logging

let me know what you need. Debugging is not so easy in Node-RED containers.

Environment

svrooij commented 6 months ago

A fix will be there shortly. It was a small change that I overlooked with the xml parser

https://github.com/svrooij/node-sonos-ts/pull/195/files#diff-3ca06a54a05a61bac9a63c4703642d7c5e8669e3b58096bf0e277a347bb8fe7cR10

svrooij commented 6 months ago

@hklages version 2.6.0-beta.11 should fix your issue npm, can you close this issue if your problem is solved?

hklages commented 6 months ago

Thanks! It works on my system and is also confirmed by another user.