search

svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
81 stars 18 forks source link

Spoken message appears as a short gap of silence if streaming/playing #38

Closed svrooij closed 4 years ago

svrooij commented 4 years ago

Issue with sonos2mqtt see https://github.com/svrooij/sonos2mqtt/issues/73

svrooij commented 4 years ago
  1. create a fork of node-sonos-ts.
  2. run npm install in the repository
  3. Change the code you want
  4. Press F5 (in VS Code), while the play-notification sample is open.

That should build (actually transpile) the typescript to javascript, and run the current open sample. The code in the repository is only TypeScript and the lib-folder is automatically ignored.

That won't help because the AsyncHelper isn't used when setting the Volume. Maybe it should be used. However that's above my experience level.

I mean that it might be better to put the delay function in the AsyncHelper class. That code might be needed in other places in the library. Something like

static async Delay(milliseconds: number): Promise {
  return await new Promise(resolve => setTimeout(resolve, 500));
}

Then you can use it by calling:

await AsyncHelper.Delay(150);
svrooij commented 4 years ago

@besynnerlig if you have fixed this issue be sure to put the following in the commit message, so it will automatically release after merge.

fix: TTS not playing

Fixed #38

The fix: will signal a new patch version. The Fixed #38 will close this issue after merging.

svrooij commented 4 years ago

:tada: This issue has been resolved in version 1.2.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: