search

svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.
https://sonos-ts.svrooij.io/
MIT License
81 stars 18 forks source link

Generated services from multiple devices #64

Closed svrooij closed 4 years ago

svrooij commented 4 years ago

Not all devices have the same services, I'm looking for a way to change the generator in a way that it will merge all the discovered-services.json from different models and turn it into a single library.

Any ideas?

See https://github.com/svrooij/sonos2mqtt/issues/104#issuecomment-643102066

https://github.com/svrooij/node-sonos-ts/compare/master...matthias-burgfried:master

matthias-burgfried commented 4 years ago

I have no idea, but if I can help you, just let me know. I could provide the services for Play:5 (G2), Beam, One (G1) and One Sl. Would the Sub (Generation 3) then also be interesting?

svrooij commented 4 years ago

Just thinking about it, would it be possible to just combine the json files from several sources. For instance, I change the generator to save the file with the model number in the name. Then you need to do a two step service generation. First generate the json files for several devices and then have the service generator combine all the services from those model specific jsons.

Would the library need to throw an "This action isn't supported on this device" error or just send the request the the device and have it fail that way?

But the original question is answered, it seems like the S2 firmware didn't implement extra endpoints. 🎉 And this library still works, that is a relieve!

github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 2.0.9-beta.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 2.0.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: