AlbumArtUri is sometimes wrong encoded

svrooij / node-sonos-ts

:speaker: Sonos control library, use this library in your own appliction.

https://sonos-ts.svrooij.io/

MIT License

84 stars 18 forks source link

AlbumArtUri is sometimes wrong encoded #93

Closed hklages closed 3 years ago

hklages commented 3 years ago

Album Art URI does not work - prime playlist, 4. Winter-Hits, Miley Cyrus Prisoner sonos-ts

http://192.168.178.37:1400/getaa?s=1&u=x-sonosapi-hls-static:catalog%2ftracks%2fB08LP1K9M3%2f%3fplaylistAsin%3dB08R3YYJG1%26playlistType%3dprimePlaylist%3fsid%3d201%26flags%3d0%26sn%3d19

With node-sonos JavaSript the result is the following and that works:
node-sonos

http://192.168.178.37:1400/getaa?s=1&u=x-sonosapi-hls-static%3acatalog%252ftracks%252fB08LP1K9M3%252f%253fplaylistAsin%253dB08R3YYJG1%2526playlistType%253dprimePlaylist%3fsid%3d201%26flags%3d0%26sn%3d19

svrooij commented 3 years ago

This seems strange.... I don't know why, but the code explicitly replaces %25 with % and %3a with :.

I've tested with spotify, and they both seem to work:

/getaa?s=1&u=x-sonos-spotify:spotify:track:7FNsGGAGyMoSwjH3ivmcep%3fsid%3d9%26flags%3d8224%26sn%3d7 (current result, with %3a replaced).
/getaa?s=1&u=x-sonos-spotify%3aspotify%3atrack%3a7FNsGGAGyMoSwjH3ivmcep%3fsid%3d9%26flags%3d8224%26sn%3d7 (without replacement)

So I would opt to remove the replacement, but to put a comment to this issue in the code. What do you think @hklages ?

svrooij commented 3 years ago

This is fixed in the latest beta right?

svrooij commented 3 years ago

@hklages can you check this issue is fixed in the latest versions?

hklages commented 3 years ago

great - it works now @2.3.0