search

svrooij / sonos2mqtt

:speaker: Sonos mqtt controller. Control your speakers from your mqtt server. mqtt-smarthome insprired.
https://sonos2mqtt.svrooij.io/
MIT License
74 stars 18 forks source link

Docker container is very long to stop #180

Closed Domochip closed 2 years ago

Domochip commented 2 years ago

I restarted my Docker server multiple times and found out that sonos2mqtt is long to stop. After verification, I can't find "Shutdown sonos2mqtt, please wait." in the log. After verification, It seems sonos2mqtt is only listening for SIGINT signal : https://github.com/svrooij/sonos2mqtt/blob/46bf61e089b77337baa287f22cd419b2bfaf3c49/src/index.ts#L18 BUT Docker start by sending a SIGTERM, then 10 sec later a SIGKILL.

First Question : do you have this kind of delay when it is deployed without Docker. Second Question : Do you want me to investigate further and make a PR to solve this.

Thanks

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 3.2.0-beta.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Domochip commented 2 years ago

I just tested the beta.6 version. Perfect, it's working fine 👍