svrooij / sonos2mqtt

:speaker: Sonos mqtt controller. Control your speakers from your mqtt server. mqtt-smarthome insprired.
https://sonos2mqtt.svrooij.io/
MIT License
76 stars 18 forks source link

EXPOSE port incorrect according to documentation #60

Closed bramwalet closed 4 years ago

bramwalet commented 4 years ago

In all parts of the documentation the listen port is specified as 6329: Examples:

Run docker run --env-file .env -p 6329:6329 svrooij/sonos2mqtt

and

Docker-compose

version: "3.7"
services:
sonos:
...
ports:
- "6329:6329"

However, the Dockerfile exposes 6326, which is incorrect / inconsistent with the provided mappings and will not work.

https://github.com/svrooij/sonos2mqtt/blob/32070c4b0e1ecdb8e8221afe580a5388e0b59db9/Dockerfile#L7

svrooij commented 4 years ago

You where right, but if you follow the documentation strictly, it will work without the expose being correct. Changed for now. But not yet in the docker image because that will be triggered on the next release that changes something to the functionality.

svrooij commented 4 years ago

:tada: This issue has been resolved in version 2.0.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: