svsticky / constipated-koala

Management system for our study association
https://koala.svsticky.nl/
GNU General Public License v3.0
16 stars 4 forks source link

Rubocop: Enforce the use of function parentheses, and auto-fix all offenses #1001

Closed Riscky closed 2 years ago

Riscky commented 2 years ago

This is an old pet peeve of mine: Ruby allows functions to be called without parentheses. In my opinion, this just makes the code less readable, especially for beginners. All changes are made my rubocop --auto-correct, which should be completely safe. The exception to this rule is a somewhat unrelated change in app/controllers/public/status_controller.rb, where 'not include' was replaced by 'exclude' by rubocop --auto-correct-all. I double-checked, and this should be safe too.