Siem2l
commented
2 years ago A possible solution would be creating a stub member and upon completion of the payment converting this stub to an actual member. In case of adding a member manually or not having a transaction fee this payment should be bypassed and instantly creating the member. Date of becoming member could be retrieved from the created_at attribute that every member has and should suffice to give enough information to the board. An alternative is already creating the member and adding a is_member column to every member which becomes true when the transaction has succeeded. Both solutions have their pros and cons so I'm not sure which one would be preferable
Riscky
Currently, Koala treats memberships as activities. This had some merits in the past, especially that it showed up in the payments page for people that didn't choose to pay directly. Since this is now made impossible (#988), this is not relevant anymore. Treating the membership payment an activity is weird, and the code handling this is not the clearest to understand. Since there is no reason to keep it this way, we should rewrite this.