search

svsticky / constipated-koala

Management system for our study association
https://koala.svsticky.nl/
GNU General Public License v3.0
16 stars 4 forks source link

Incorrect email verification pattern #1054

Closed SpookyBoy99 closed 8 months ago

SpookyBoy99 commented 8 months ago

Expected behaviour

Changing email address to a ".codes" domain succeeds.

Actual behavior

Emails with a codes TLD are not seen as a valid email address

Steps to reproduce

Mstiekema commented 8 months ago

I've checked our email regex and a domain like example@example.codes should work. Also tested on staging, you can create a user with a .codes domain.

Can you provide more information?

SpookyBoy99 commented 8 months ago

Due to confidentially reasons, I cannot give the exact email, however, I've noticed that it that on staging the email I intend to use does work, on the live version it does not work however. When I enter the email, it gives the message that a confirmation email is sent to the address that was just entered, however, it also gives an error message saying that the email address is invalid. When reloading the page or navigating to the overview page, the email is reset to the old email address.

From: Merijn Stiekema @.> Sent: Wednesday, October 18, 2023 08:31 To: svsticky/constipated-koala @.> Cc: SpookyBoy99 @.>; Author @.> Subject: Re: [svsticky/constipated-koala] Incorrect email verification pattern (Issue #1054)

I've checked our email regex and a domain like @.**@.> should work. Also tested on staging, you can create a user with a .codes domain.

Can you provide more information?

— Reply to this email directly, view it on GitHubhttps://github.com/svsticky/constipated-koala/issues/1054#issuecomment-1767760843, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOVFWWENOL6ZCDVUXP663G3X75ZVHAVCNFSM6AAAAAA5YVWNOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXG43DAOBUGM. You are receiving this because you authored the thread.Message ID: @.***>

Mstiekema commented 8 months ago

Issue is no longer relevant. User had an old account with a students.uu.nl email account which is no longer possible, which broke the email update function.