Force email change is broken

svsticky / constipated-koala

Management system for our study association

https://koala.svsticky.nl/

GNU General Public License v3.0

16 stars 4 forks source link

Force email change is broken #939

Closed Riscky closed 2 years ago

Riscky commented 2 years ago

Reproducing the issue:

Change the email address of test@svsticky.nl (or any member with an account, but in development this is the only member with an account)
The page now shows "A confirmation mail is send to test2@svsticky.nl, once confirmed the e-mailadress will be updated. Or force the change here."
Click force, and see the following error: " ActionController::ParameterMissing in Admin::MembersController#force_email_change "

Riscky commented 2 years ago

Sentry bug details:

ActionController::ParameterMissing: param is missing or the value is empty: member
Did you mean?  member_id
               _method
               authenticity_token
               controller
  app/controllers/admin/members_controller.rb:164:in `member_post_params'
    params.require(:member).permit(:first_name,
  app/controllers/admin/members_controller.rb:94:in `force_email_change'
    ENV['MAILCHIMP_DATACENTER'].blank? || member_post_params[:mailchimp_interests].nil?