This closes #926 by adding rubocop-rails to rubocop.
This add a whole bunch of new checks for code readability, some of which are safely auto-correctable.
Those have been fixed, the other failing checks have been added to the TODO list.
I could have fixed more, but that would have made this PR a bit too large.
There is an outstanding issue to resolve the TODO list here: #930
Note to reviewers: all code changes have been made by a command (rubocop --auto-fix), and as such functionality should be unchanged.
This closes #926 by adding rubocop-rails to rubocop.
This add a whole bunch of new checks for code readability, some of which are safely auto-correctable. Those have been fixed, the other failing checks have been added to the TODO list. I could have fixed more, but that would have made this PR a bit too large. There is an outstanding issue to resolve the TODO list here: #930
Note to reviewers: all code changes have been made by a command (
rubocop --auto-fix), and as such functionality should be unchanged.