svsticky / pxl

Manage photo albums on S3 buckets
https://pxl-demo.svsticky.nl
Mozilla Public License 2.0
17 stars 2 forks source link

Swipe left/right for next/previous picture #45

Open Ckef opened 5 years ago

Ckef commented 5 years ago

In addition to the left/right buttons, swiping would be nice on mobile.

duijf commented 5 years ago

I think swipe to navigate is nice, but one of the explicit goals of pxl (and the reason we got it out of the door in < 200 commits) is to not re-implement stuff that browsers do already.

That being said; I'd be delighted to accept a well-written pull request which implements swipe navigation in a nice polished way. However, I am a bit pessimistic about the chances of such an effort; especially on whether the implementation would be a net-win for all users.

I am concerned about:

I feel this way because there isn't a standard/browser API for detecting gestures. There's touchstart/touchmove/touchend, but then you end up with code like this: https://stackoverflow.com/a/23230280/2099958

So you have two options:

I'd judge a potential PR implementing this on: