svsticky / pxl

Manage photo albums on S3 buckets
https://pxl-demo.svsticky.nl
Mozilla Public License 2.0
17 stars 2 forks source link

Ready for Review: added an cli option to delete an album with its pictures #54

Closed Riscky closed 4 years ago

Riscky commented 5 years ago

Status: Done, pls review

Added a command line option to remove an album, including its pictures. Use pxl delete "Album name" to delete its pictures from the file hosting and remove the album from the state, in that order. If the given album name does not match any known album the operation is cancelled.

Biggest drawback of this implementation is that the pictures are removed from the file hosting before the site is rebuild and deployed, leaving a window in which the album appears to have missing pictures. The user is warned of this issue after the operation finishes.

duijf commented 5 years ago

Hey thanks for the PR!

Please:

HugoPeters1024 commented 5 years ago

@Riscky Could you also please rename (and potentially squash) the commits to a "subject: short description" like format to make it match the rest of the commit history?