svsticky / sadserver

Documentation and configuration management of Study Association Sticky's servers
Other
7 stars 1 forks source link

Implement photo gallery application #174

Closed tomwassenberg closed 5 years ago

tomwassenberg commented 6 years ago

We need an alternative to Flickr, to host our "public" photos. Incomplete list of requirements:

duijf commented 6 years ago
martijncasteel commented 6 years ago

Basically a flickr clone, it shouldn't be that hard. I started something small however discontinued it since the commit is willing to implement such an application. My advice would be to build it in rails since there is some experience there and use paperclip as well.

arianvp commented 6 years ago

I would refrain from adding tagging functionality. As it complicates GDPR compliance

duijf commented 6 years ago

I would refrain from adding tagging functionality. As it complicates GDPR compliance

Yeah, let's not go there. As soon as you know who is in a photo, that photo is considered sensitive data on that person (as a lot of sensitive data can be inferred from it)

Let's shoot for the bare minimum first, and then add enhancements later :)

martijncasteel commented 6 years ago

I assumed that a picture of your person is sensitive data in the first place. An option to tag enables you to flag inappropiate photos earlier. But offcourse first the minimum viable product!

emielvanrijn1 commented 6 years ago

Several members said they would like to be able to see photos of activities within the corresponding activity in Koala. This would means we would have to change how activities are handled at the moment. But first, let me ask the million-dollar question, do we actually want this? If so, than activities should become visible even after attended (now hidden from regular users), but this means we should also hide the attendees list when an activity is displayed after the activity has taken place, because otherwise with a little deduction, it would be the same as tagging. Pros of this approach are that photos are clustered by activities, a user has already have to be logged in into koala to view the photos. Con is, that it is yet another feature in koala, and I know @martijncasteel isn't all to fond of these kind of features being added.

The other option we discussed was adding a photos section to svsticky.nl, where a member would have to OAuth with its koala account to get access to this restricted area on the website. Pros are that it would be quite a bit easier to maintain as it would be 'just' an extra seperate component to the list, and several React libraries exist for displaying photos nicely in grids and the like. Another pro is that a user that hasn't attended an activity is able to view photos of this activity, and thus can 'taste' the atmosphere. Con is that it might be a little harder to match photos to activities, and that I am not aware of the current status of the OAuth and if this is easily doable.

Please let me know your comments, all of you :)!

martijncasteel commented 6 years ago

@emielvanrijn I think pictures would be a nice addition to koala. However this would probably require an overhaul of the membership pages. Still I think a refactor of currently functionality wouldn't be a bad idea. Perhaps make koala extensible with plugins (https://guides.rubyonrails.org/engines.html).

However file storage in rails doesn't has great support, the gem for file storage (https://robots.thoughtbot.com/closing-the-trombone) is deprecated and the new default from rails itself has bad support for authorization (and ugly url's).

tomwassenberg commented 5 years ago

There has been a photo application available for some time at https://photos.svsticky.nl/, without major issues, mostly thanks to @duijf. Closing this!