svthalia / Reaxit

The latest ThaliApp built on Flutter.
GNU General Public License v3.0
11 stars 3 forks source link

Adapt to changes to the TOSTI api #414

Closed DeD1rk closed 1 year ago

DeD1rk commented 1 year ago

After this I hope the TOSTI client works again.

Summary

Just updates models to match some API changes.

How to test

Steps to test the changes you made:

  1. Go to a tosti shift, order, etc.
DeD1rk commented 1 year ago

I don't feel like testing on localhost because motivation, so maybe we can just test with the actual tosti shift tomorrow?

JAicewizard commented 1 year ago

Yeah I can try to order tostis tomorrow.

JAicewizard commented 1 year ago

Code looks good, so if ordering a tosti works tomorrow I think its gtg

DeD1rk commented 1 year ago

Nice, it looks like apple may secretly be ratelimiting our uploads though :( Maybe we should make deploy take a manual trigger/push-master only

JAicewizard commented 1 year ago

They should just take less time to upload :( I agree that if apple is ratelimmiting us we should only deploy to apple on push to master automatically, or a manual trigger. Bit of a shame, since it takes so long to deploy so reviews will take longer.

Do you have any idea when apple sideloading might be released? Maybe you can use that for reviewing instead of the appstore

DeD1rk commented 1 year ago

Do you have any idea when apple sideloading might be released?

With ios 17, so most likely in september.

Most of the builds are mostly useless though, so a manual trigger to deploy PRs is probably fine.

DeD1rk commented 1 year ago

Ik heb lekkere tostis besteld :)