search

svthalia / Reaxit

The latest ThaliApp built on Flutter.
GNU General Public License v3.0
11 stars 3 forks source link

Accept photos responses without rotations #437

Closed DeD1rk closed 1 year ago

DeD1rk commented 1 year ago

What

In preparation of https://github.com/svthalia/concrexit/issues/3133, it would be nice if the app already supports getting no rotation in photo responses from the API. For now, rotation can just get 0 by default if not specified. Once concrexit does rotation internally, rotation can be dropped altogether, but this way we won't have incompatibility issues.

Why

Because rotation as it is right now is messy.

How

Set a default on the model (with a jsonKey decorator I guess)

DeD1rk commented 1 year ago

Due to https://github.com/svthalia/concrexit/issues/3311, this should also remove the hidden field. That's not used so can be dropped entirely.