svthalia / Reaxit

The latest ThaliApp built on Flutter.
GNU General Public License v3.0
11 stars 3 forks source link

FormatException: FormatException: Invalid radix-10 number (at character 1) #452

Closed sentry-io[bot] closed 2 months ago

sentry-io[bot] commented 1 year ago

Sentry Issue: THALIAPP-M3

FormatException: FormatException: Invalid radix-10 number (at character 1)
boards
^

  File "routes.dart", line 306, in routes.<fn>
  File "builder.dart", line 354, in RouteBuilder._buildPageForGoRoute
  File "builder.dart", line 212, in RouteBuilder._buildRecursive
  File "builder.dart", line 220, in RouteBuilder._buildRecursive
  File "builder.dart", line 153, in RouteBuilder._buildPages
...
(41 additional frame(s) were not displayed)
JAicewizard commented 1 year ago

@Scarletto Do you remember why we needed https://github.com/svthalia/Reaxit/commit/a5d7e99edfdc99dc16d0ca41ee31bca4ee3a479d#diff-db86e4d234b8ce36f13aae12c233aec35d10552b4b295edf1a456ae87fb16bbbR297-R304?

I can not see any point in the app which directs to it and neither can I find a way to access it via a deeplink

Scarletto commented 1 year ago

We used to have a route named 'board' so I probably figured I would add one with the same name. Since the distinction in pk-based groups is gone, if it causes problems you can just remove it.

That said, it is just a copypaste of the 'group' route so it not working might indicate some other issue.

On Thu, 27 Jul 2023, 14:52 Jaap Aarts, @.***> wrote:

@Scarletto https://github.com/Scarletto Do you remember why we needed a5d7e99

diff-db86e4d234b8ce36f13aae12c233aec35d10552b4b295edf1a456ae87fb16bbbR297-R304

https://github.com/svthalia/Reaxit/commit/a5d7e99edfdc99dc16d0ca41ee31bca4ee3a479d#diff-db86e4d234b8ce36f13aae12c233aec35d10552b4b295edf1a456ae87fb16bbbR297-R304 ?

I can not see any point in the app which directs to it and neither can I find a way to access it via a deeplink

— Reply to this email directly, view it on GitHub https://github.com/svthalia/Reaxit/issues/452#issuecomment-1653562205, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF54SZPKQSAHJZTQIBVL4CTXSJQCFANCNFSM6AAAAAAZ7MFTQI . You are receiving this because you were mentioned.Message ID: @.***>

JAicewizard commented 1 year ago

This seems to be due to the order of the routes. If you open /associations/boards in the app, it gets routed to /groups/boards which then goes to the crashing line (edit: because it is earlier than the /boards subroute)

JAicewizard commented 1 year ago

Just verified the same goes for all group redirects