search

svthalia / Reaxit

The latest ThaliApp built on Flutter.
GNU General Public License v3.0
11 stars 3 forks source link

Fix previously filtered events not showing on the calendar #469

Closed JAicewizard closed 10 months ago

JAicewizard commented 10 months ago

Closes #468.

Summary

Previously, a mistake in interpreting the dart syntax led to previous events being cleared before using them.

How to test

Steps to test the changes you made:

  1. Go to calendar
  2. Scroll down to the bottom
  3. See study trip
DeD1rk commented 10 months ago

Wait so what syntqx was wrong? Does the ... = x + y == z do ... = x + 1? That wouldn't make sense i guess

JAicewizard commented 10 months ago

The syntax issue is with ..clear(). Since it returns the object after clearing the List. The rest is just making it a bit cleaner

DeD1rk commented 10 months ago

Ah that explains it yeah, good find

DeD1rk commented 10 months ago

Maybe a test would be good?

JAicewizard commented 10 months ago

Implemented the test, based on a new PR #472