svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
22 stars 12 forks source link

Disable Thalia Pay payments for specific events #1422

Closed JobDoesburg closed 3 years ago

JobDoesburg commented 3 years ago

Is your feature request related to a problem? Please describe.

There might be events where Thalia Pay should not be available (study trip, events where the payment amount is variable like the orientation bbq, events where registration is not first come first serve like wine tasting or committee lunch)

Describe the solution you'd like

An option in the events admin that sets whether Thalia Pay is allowed for this event. The default should be true. When false, the payment button should not appear.

Probably we should also add something to the Payable interface about this so we can implement the same check in the process_payment code.

Motivation

Thalia Pay is quite critical and should work as intended always without too much manual hassle.

Describe alternatives you've considered

Manually removing payments that we do not want.

Additional context

JobDoesburg commented 3 years ago

The change to the Payable-interface is probably also nice to use in #1386 to prevent people from paying orders that are not complete yet