svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
23 stars 11 forks source link

Deleting user doesn't delete their email from members@ mailinglist #1897

Open Jorritboer opened 2 years ago

Jorritboer commented 2 years ago

Describe the bug

I have deleted a user after they explicitly asked me to do so but this person hasn't been deleted from the members@ Google Group.

How to reproduce

Steps to reproduce the behaviour:

  1. Delete a user
  2. See their email address still in the members@ Google Group

Expected behaviour

The user should be deleted from the group, just like when a user stops being a member.

se-bastiaan commented 2 years ago

What timeframe are we talking about? The mailing list is only synced every hour.

The syncing code takes all the member addresses and if they are in the current list, but not the new one it removes them. So it should technically work.

I am assuming that this person still had an active membership? Really need some more info since I think we do not always take into account that we will delete users that are still active. Bit of a vague situation now.

Jorritboer commented 2 years ago

I deleted this user on March 1, and on August 21 I received an email that he was still receiving emails sent to members@thalia.nu and if he could please be deleted.

Jorritboer commented 2 years ago

It is possible that this user still had an active membership before I deleted them, I don't know and can't check anymore because their account has been deleted

se-bastiaan commented 2 years ago

I guess that just means we have to try:

  1. Deleting a user with active membership
  2. Deleting a user without active membership

If the user did not have a membership any more their data should have been minimised on March 1st as well

@Jorritboer are you sure the member is now no longer in the mailinglist?

JobDoesburg commented 2 years ago

@SnevelRetlaw can you perhaps verify this issue?