search

svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
22 stars 12 forks source link

Catch exceptions during image uploading #264

Closed thaliawww-service closed 4 years ago

thaliawww-service commented 4 years ago

In GitLab by @se-bastiaan on Dec 21, 2016, 11:07

Nu gaat t uploaden fout bij een archive en niet-afbeeldingen. En werkt t totaal niet, het album wordt niet aangemaakt. Het zou mooier zijn als de daadwerkelijke afbeeldingen wel worden toegevoegd en het album wordt aangemaakt.

thaliawww-service commented 4 years ago

In GitLab by @joostrijneveld on Dec 21, 2016, 11:10

Aanvullend: samenvatten welke bestanden genegeerd zijn lijkt wel waardevol, om misverstanden te voorkomen. De relevante traceback:

ERROR (EXTERNAL IP): Internal Server Error: /admin/photos/album/add/
Internal Server Error: /admin/photos/album/add/

OSError at /admin/photos/album/add/
cannot identify image file '/concrexit/media/photos/22-12-2016-lasergamen/._IMG_5906.JPG'

Request Method: POST
Request URL: https://thalia.nu/admin/photos/album/add/

Traceback:  

File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
 39.             response = get_response(request)

File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
 187.                 response = self.process_exception_by_middleware(e, request)

File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
 185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/usr/local/lib/python3.5/site-packages/django/contrib/admin/options.py" in wrapper
 544.                 return self.admin_site.admin_view(view)(*args, **kwargs)

File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in _wrapped_view
 149.                     response = view_func(request, *args, **kwargs)

File "/usr/local/lib/python3.5/site-packages/django/views/decorators/cache.py" in _wrapped_view_func
 57.         response = view_func(request, *args, **kwargs)

File "/usr/local/lib/python3.5/site-packages/django/contrib/admin/sites.py" in inner
 211.             return view(request, *args, **kwargs)

File "/usr/local/lib/python3.5/site-packages/django/contrib/admin/options.py" in add_view
 1509.         return self.changeform_view(request, None, form_url, extra_context)

File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in _wrapper
 67.             return bound_func(*args, **kwargs)

File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in _wrapped_view
 149.                     response = view_func(request, *args, **kwargs)

File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in bound_func
 63.                 return func.__get__(self, type(self))(*args2, **kwargs2)

File "/usr/local/lib/python3.5/contextlib.py" in inner
 30.                 return func(*args, **kwds)

File "/usr/local/lib/python3.5/site-packages/django/contrib/admin/options.py" in changeform_view
 1449.                 self.save_model(request, new_object, form, not add)

File "./photos/admin.py" in save_model
 56.                     photo_obj.file.save(photo_filename, ContentFile(f.read()))

File "/usr/local/lib/python3.5/site-packages/django/db/models/fields/files.py" in save
 97.             self.instance.save()

File "./photos/models.py" in save
 43.             image = Image.open(image_path)

File "/usr/local/lib/python3.5/site-packages/PIL/Image.py" in open
 2319.                   % (filename if filename else fp))

Exception Type: OSError at /admin/photos/album/add/
Exception Value: cannot identify image file '/concrexit/media/photos/22-12-2016-lasergamen/._IMG_5906.JPG'
thaliawww-service commented 4 years ago

In GitLab by @joostrijneveld on Dec 21, 2016, 19:10

assigned to @joostrijneveld

thaliawww-service commented 4 years ago

In GitLab by @joostrijneveld on Dec 21, 2016, 19:10

created branch 262-catch-exceptions-during-image-uploading

thaliawww-service commented 4 years ago

In GitLab by @thomwiggers on Dec 21, 2016, 19:29

Meerdere keren uploaden van dezelfde bestanden zou ook afgehandeld moeten worden though, voordat we hele albums verdubbelen (#197)

thaliawww-service commented 4 years ago

In GitLab by @joostrijneveld on Dec 21, 2016, 19:33

Lijkt me een andere issue toch?

thaliawww-service commented 4 years ago

In GitLab by @thomwiggers on Dec 21, 2016, 19:34

Mja maar als je nu 'halve' albums gaat maken dan wordt #197 waarschijnlijk wat kritieker bij de herkansingen.

thaliawww-service commented 4 years ago

In GitLab by @joostrijneveld on Dec 21, 2016, 19:36

Sure, maar dit gaat typisch over gekke onzichtbare bestanden die je toch niet wil, ipv over 'halve albums', toch?

thaliawww-service commented 4 years ago

In GitLab by @lscholten on Dec 21, 2016, 19:53

closed via commit 0e4a8874fbf899f66d9033d23a844e412236d5eb

thaliawww-service commented 4 years ago

In GitLab by @lscholten on Dec 21, 2016, 19:53

closed via merge request !275

thaliawww-service commented 4 years ago

In GitLab by @thomwiggers on Dec 21, 2016, 19:54

ah ok, yeah die leiden niet zo gauw tot nieuwe pogingen. Video's allicht wel.

thaliawww-service commented 4 years ago

In GitLab by @joostrijneveld on Dec 21, 2016, 19:56

Wellicht, maar dan lijkt 't me aan de uploader om slim genoeg te zijn om niet alles opnieuw te uploaden (in ieder geval totdat #197 af is)

thaliawww-service commented 4 years ago

In GitLab by @lscholten on Dec 21, 2016, 21:29

mentioned in commit 0e4a8874fbf899f66d9033d23a844e412236d5eb