search

svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
23 stars 11 forks source link

Optimize fetch_thumbnails #3624

Closed DeD1rk closed 3 months ago

DeD1rk commented 4 months ago

In case of a redis backend, this should prevent doing a redis pipeline that looks for a thumbnail for image "" many times, for each empty image field (such as a member without profile picture).

Consider for example this (partial) redis pipeline call from sentry:

"HGETALL 'djthumbs:thumbnails:avatars/98a3dd0519bae43a2bfc45f2bb8653a0.jpg'",
"HGETALL 'djthumbs:thumbnails:'",
"HGETALL 'djthumbs:thumbnails:'",
"HGETALL 'djthumbs:thumbnails:avatars/1152ba8439c354c207967279fcbf4fcb.jpg'",
"HGETALL 'djthumbs:thumbnails:'",
// ... (45 more)
image