search

svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
23 stars 12 forks source link

committees with no members are not handled well. #3635

Closed JAicewizard closed 5 months ago

JAicewizard commented 6 months ago

Describe the bug

Committees with no members have a weird piece of text instead of members list. Currently it says "This group doesn't have any members?"

How to reproduce

  1. Go to https://thalia.nu/association/committees/46/
  2. This group doesn't have any members?

Expected behaviour

This should not have a members section, or have a text indicating there are no members. This should not be a question, but a statement.

Additional context

Ideally there should be a type of committee "Former committee", under which the bit committee would fall, with a text saying this committee no longer exists. However this is probably really annoying, and changing the "?" into a "." is a good enough fix.

I heard people wanted to solve issues with as little character changes as possible, so here you go, it almost cant get any smaller.

DeD1rk commented 6 months ago

This committee is actually supposed to be inactive (we already have a boolean flag and start-end dates for that) and hence doesn't show up on the committees list. But of course it remains in profiles.

That should be handled better indeed. Perhaps also with an explicit indication that the committee is inactive/disbanded/whatever