search

svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
23 stars 12 forks source link

Fork django-thumbnails? #3637

Open DeD1rk opened 6 months ago

DeD1rk commented 6 months ago

What?

I think we should maybe fork django-thumbnails, as it's not being maintained.

Why?

Then we can swap out its image processing library ('davinci') for pure Pillow, allowing us to use an up-to-date Pillow version. And we can just make it a bit nicer in general.

How?

Make a fork in svthalia, get rid of davinci, specify a newer Pillow dependency range, move our own fetch_thumbnails function into it, etc.

We can just install it with a public git url, no need to distribute to PyPI (yet) for our usecase.

DeD1rk commented 4 months ago

It seems that the old pillow version required by davinci doesn't run (it installs but crashes at runtime) on M1 macs (haven't verified that the latest version works at runtime but I assume so).

That's a pretty good reason to get rid of it.

DeD1rk commented 4 months ago

Update: actually, davinci supposedly should support Pillow 10 now. So there's no need to do it for that. But still worthwhile just to get some more control over it and merge e.g. our fetch_thumbnails improvements.