svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
23 stars 11 forks source link

Import events into newsletter #3650

Open ColonelPhantom opened 3 months ago

ColonelPhantom commented 3 months ago

Closes #2162 Closes #3317

Summary

As you can see, apart from the headline feature there's a handful of refactors here as well.

I considered rewriting the newsletter app to use actual event references, but this is inflexible due to things like external events and would also require us to keep the current system alongside it to prevent breaking changes in our schema.

How to test

  1. Create a newsletter.
  2. Click the nice pink Import events button.
  3. Fill in the options.
  4. Check that all the events you wanted appeared.
ColonelPhantom commented 3 months ago

By the way, do we really want the duplicate action buttons on the page? IMO it looks ugly, especially with the bottom one being below the save buttons and stuff. I'd vote for removing that bar and just having the actions on top only. Opinions?

JeeVee11 commented 2 months ago

I think that for defaults its the events of next week are the best.

Does this also include adding automatically adding events for which the registration opens in the next week, not just events that happen?

ColonelPhantom commented 2 months ago

Does this also include adding automatically adding events for which the registration opens in the next week, not just events that happen?

The idea is that you can fill in date ranges for both, and any event that satisfies either of them will be added.

I did just realize that what currently happens is that only events that satisfy both ranges will be added. Probably requiring only one of them would be much better.

ColonelPhantom commented 1 month ago

I fixed the logic. Additionally, I restored the 'event' field on the form to make sure it is still easy to add/edit single events.