Open ColonelPhantom opened 3 months ago
By the way, do we really want the duplicate action buttons on the page? IMO it looks ugly, especially with the bottom one being below the save buttons and stuff. I'd vote for removing that bar and just having the actions on top only. Opinions?
I think that for defaults its the events of next week are the best.
Does this also include adding automatically adding events for which the registration opens in the next week, not just events that happen?
Does this also include adding automatically adding events for which the registration opens in the next week, not just events that happen?
The idea is that you can fill in date ranges for both, and any event that satisfies either of them will be added.
I did just realize that what currently happens is that only events that satisfy both ranges will be added. Probably requiring only one of them would be much better.
I fixed the logic. Additionally, I restored the 'event' field on the form to make sure it is still easy to add/edit single events.
Closes #2162 Closes #3317
Summary
event
field for newsletter events, since this field was not used and kinda pointless (it was never used as far as I could see).As you can see, apart from the headline feature there's a handful of refactors here as well.
I considered rewriting the newsletter app to use actual event references, but this is inflexible due to things like external events and would also require us to keep the current system alongside it to prevent breaking changes in our schema.
How to test
Import events
button.