svthalia / concrexit

Thalia Website built on Django.
https://thalia.nu
Other
23 stars 11 forks source link

Fix trying to delete moneybird invoice that has already been removed on moneybird #3691

Closed DeD1rk closed 1 month ago

DeD1rk commented 1 month ago

Describe the bug

CONCREXIT-1D2

When trying to delete moneybird external invoices, if they have already been removed on moneybird, it currently cuases this issue where the DELETE request fails with 404. Instead, we can probably just accept that it's already been done (and log a warning).

How to reproduce

  1. Have an invoice that's been synced to moneybird.
  2. Delete the invoice from moneybird, and make the payable be deleted from concrexit.
  3. When at night we try to delete it from moneybird, get a 404.

Expected behaviour

When we try to delete it from moneybirds api, we ignore the 404.